alamb commented on code in PR #14860:
URL: https://github.com/apache/datafusion/pull/14860#discussion_r1970300873
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -63,6 +63,26 @@ use indexmap::IndexSet;
/// Default table name for unnamed table
pub const UNNAMED_TABLE: &str = "?table?";
+/// Options for [`LogicalPlanBuilder`]
+#[derive(Default, Debug, Clone)]
+pub struct LogicalPlanBuilderOptions {
+ /// Flag indicating whether the plan builder should add
+ /// functionally dependent expressions as additional aggregation groupings.
+ add_implicit_group_by_exprs: bool,
Review Comment:
I agree it would be less surprising, but I think we should consider it in a
follow on PR. This PR fixes the issue with substrait and is a good change on
its own. I have filed a follow on ticket to track the idea:
- https://github.com/apache/datafusion/issues/14878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
