anlinc commented on code in PR #14860:
URL: https://github.com/apache/datafusion/pull/14860#discussion_r1970051636
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -63,6 +63,26 @@ use indexmap::IndexSet;
/// Default table name for unnamed table
pub const UNNAMED_TABLE: &str = "?table?";
+/// Options for [`LogicalPlanBuilder`]
+#[derive(Default, Debug, Clone)]
+pub struct LogicalPlanBuilderOptions {
+ /// Flag indicating whether the plan builder should add
+ /// functionally dependent expressions as additional aggregation groupings.
+ add_implicit_group_by_exprs: bool,
Review Comment:
Although admittedly, I was not aware that this was going to be a breaking
change, since SQL and Dataframes maintain the same behavior.
@vbarua informed me that it may be possible that there are those depending
on the builder directly. In which case, I can see an argument for maintaining
the default `true` behavior...
I'm a new contributor to this project so I'm lacking context. I might lean
on you folks to make a more informed decision here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
