irenjj opened a new issue, #14914:
URL: https://github.com/apache/datafusion/issues/14914

   ### Is your feature request related to a problem or challenge?
   
   ## Summary
   [#14677](https://github.com/apache/datafusion/pull/14677) introduces basic 
tree rendering for SQL EXPLAIN output but requires follow-up work to improve 
completeness, test coverage, and code quality. Below are the key tasks and 
enhancements needed:
   
   ### Information Completion
   The current implementation lacks detailed information for many physical 
plans.
   
   Add rendering logic for missing operators (In every physical plan's `fmt_as` 
function).
   
   ### Test Coverage Expansion
   
   #### Long Metric Entries
   Add tests for plans with long metrics (e.g., partition_sizes: [20, 20, 20, 
30, ...]) to validate line-wrapping and truncation logic.
   
   #### Complex Queries
   Incorporate TPCH queries (e.g., Q5, Q9) to test rendering of deeply nested 
plans.
   
   Validate alignment and indentation for multi-level operators.
   
   ### Code Cleanup & Improvements
   #### TODOs
   Address line-length checks:
   ```
   // TODO: check every line is less than MAX_LINE_RENDER_SIZE.  
   ```
   Make variables (e.g., indentation size, truncation thresholds) configurable:
   ```
   // TODO: Make these variables configurable.  
   ```
   #### Dead Code Removal
   Remove or utilize the unused Coordinate struct:
   ```rust
   #[allow(dead_code)]  
   pub struct Coordinate { ... }  
   // TODO: It's never used.  
   ```
   
   ### Describe the solution you'd like
   
   _No response_
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to