AdamGS opened a new pull request, #14951:
URL: https://github.com/apache/datafusion/pull/14951
## Which issue does this PR close?
Part of #14444.
The PR is obviously huge, but because the file are split (keeping tests in
core), github doesn't understand some of the changes as moves, even though
that's the majority of the change.
I've read through it a couple of times and kept finding small things that
can be improved and I'll probably do that again during the weekend.
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
Moving all format-specific functionality into dedicated crates, introducing:
- `datafusion-datasource-csv`
- `datafusion-datasource-json`
- `datafusion-datasource-avro`
- `datafusion-datasource-parquet`
Along the way I managed to move some stuff into `datasource` and tried
multiple times to move tests infrastructure, but I think I ended pretty close
to where I started.
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
## Are there any user-facing changes?
I tried to maintain the current exposed modules and types, and keep them
sane in general.
I'm not sure I managed to keep all of them but I think none got
significantly more complex to pull in.
There is more public API surface now, as some of the shared code used its
location to stay `pub(crate)` or just private (for example - the `Decoder`
trait and related pieces).
I also moved a couple of functions from `SessionState` to session, one tiny
step towards that goal.
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
