AdamGS commented on code in PR #14951:
URL: https://github.com/apache/datafusion/pull/14951#discussion_r1976488608
##########
datafusion/core/src/execution/session_state.rs:
##########
@@ -832,17 +836,16 @@ impl SessionState {
self.config.options()
}
- /// return the TableOptions options with its extensions
- pub fn default_table_options(&self) -> TableOptions {
- self.table_options
- .combine_with_session_config(self.config_options())
- }
-
/// Return the table options
pub fn table_options(&self) -> &TableOptions {
&self.table_options
}
+ /// return the TableOptions options with its extensions
+ pub fn default_table_options(&self) -> TableOptions {
+ Session::default_table_options(self)
+ }
+
Review Comment:
If I change the function here to:
```rust
/// return the TableOptions options with its extensions
pub fn default_table_options(&self) -> TableOptions {
self.default_table_options()
}
```
clippy tells me its a recursion and the stack blows up when I run tests.
I think the default implementation here messes with with just having the
trait implementation delegate to the struct. Of course I can copy it here and
make the implementation delegate to it but that seems like unnecessary code
duplication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
