robtandy commented on PR #71:
URL: https://github.com/apache/datafusion-ray/pull/71#issuecomment-2692803224
Thank you @andygrove !
A few suggestions:
- Can we call `Greedy`, `Streaming`? I think its more communicative about
how it functions and conveys its major feature in the name.
- for the code snippet, I think it should read:
````python
import ray
from datafusion_ray import DFRayContext
ray.init()
session = DFRayContext()
df = session.sql("SELECT * FROM my_table WHERE value > 100")
df.show()
````
- I'm not sure about the trade offs as written. I think its possible that,
depending on the query, a batch mode could be faster than a streaming mode for
smaller queries due to less overhead. We'll have to implement the batch mode
to define this more clearly.
- We should indicate that the batch mode is planned for `0.2.0` and `0.1.0`
will include Streaming only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
