khushishukla2813 opened a new pull request, #14989: URL: https://github.com/apache/datafusion/pull/14989
## Which issue does this PR close? - Closes #14796 ## Rationale for this change This change addresses an issue where inline crate-level documentation attributes (using `#![doc(...)]`) could not be generated via a procedural macro, resulting in errors like "inner attribute is not permitted in this context." By replacing these inline attributes with a centralized `doc_cfg!()` macro (defined via `macro_rules!`), we can manage the logo and favicon URLs in one place. This not only resolves the inner attribute issue but also improves maintainability. ## What changes are included in this PR? - Removed the inline `#![doc(...)]` and `#![cfg_attr(...)]` attributes from `user_docs.rs`. - Introduced a `doc_cfg!()` macro that centralizes the configuration of the documentation logo and favicon. - Updated `user_docs.rs` to use the new macro (either by defining it directly in the file or by importing it from a separate module). ## Are these changes tested? Yes, the changes have been tested locally by running `cargo doc` and verifying that the generated documentation correctly displays the updated logo and favicon. (Existing tests indirectly cover this change by ensuring the documentation builds without errors.) ## Are there any user-facing changes? Yes, users will see the updated logo and favicon on the generated documentation pages. There are no functional changes to the API or underlying behavior—this is purely a documentation enhancement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
