khushishukla2813 commented on code in PR #14989: URL: https://github.com/apache/datafusion/pull/14989#discussion_r1979134788
########## datafusion/macros/src/macros.rs: ########## @@ -0,0 +1,10 @@ +#[macro_export] Review Comment: > Maybe add a `proc-macros` crate, move the proc macros there and re-export them from the current macros crate? well ...I removed proc-macro = true so macro_rules! works from a normal library crate. Let me know if needs any other changes!" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
