comphead commented on PR #1456:
URL:
https://github.com/apache/datafusion-comet/pull/1456#issuecomment-2698592405
> In `CometExecRule` we check to see if we support the partitioning types
for the shuffle but do not check that we support the types of other columns.
>
> @comphead Do you want to update these checks as part of this PR and see if
it resolves the issue?
>
> ```scala
> case class CometExecRule(session: SparkSession) extends Rule[SparkPlan] {
> private def applyCometShuffle(plan: SparkPlan): SparkPlan = {
> plan.transformUp {
> case s: ShuffleExchangeExec
> if isCometPlan(s.child) && isCometNativeShuffleMode(conf) &&
> QueryPlanSerde.supportPartitioning(s.child.output,
s.outputPartitioning)._1 =>
> ...
>
>
> case s: ShuffleExchangeExec
> if (!s.child.supportsColumnar || isCometPlan(s.child)) &&
isCometJVMShuffleMode(
> conf) &&
> QueryPlanSerde.supportPartitioningTypes(s.child.output,
s.outputPartitioning)._1 &&
> !isShuffleOperator(s.child) =>
> ...
> ```
Thanks @andygrove I'll check that, you saving me hours of debugging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
