comphead commented on code in PR #1456:
URL: https://github.com/apache/datafusion-comet/pull/1456#discussion_r2001739415
##########
native/core/Cargo.toml:
##########
@@ -77,6 +77,7 @@ jni = { version = "0.21", features = ["invocation"] }
lazy_static = "1.4"
assertables = "7"
hex = "0.4.3"
+datafusion-functions-nested = "46.0.0"
Review Comment:
I'm not sure if it is possible to make it `workspace = true`, this package
is optional for test only and optional packages are not allowed on workspace
level.
I can include it in workspace as non optional but it will be compiled into
the target binary which is probably not expected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
