comphead commented on code in PR #14995:
URL: https://github.com/apache/datafusion/pull/14995#discussion_r1980248722
##########
datafusion/physical-plan/src/stream.rs:
##########
@@ -241,8 +241,17 @@ impl RecordBatchReceiverStreamBuilder {
self.inner.spawn(task)
}
- /// Spawn a blocking task that will be aborted if this builder (or the
stream
- /// built from it) are dropped
+ /// Spawns a blocking task that attempts to send `RecordBatch` data to
this stream.
+ ///
+ /// If this builder (or the stream built from it) is dropped **before**
the task starts,
Review Comment:
I think here can be some confusion. Task will never executes does that mean
the task ignored or it is stuck in waiting queue forever?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
