comphead commented on code in PR #14995:
URL: https://github.com/apache/datafusion/pull/14995#discussion_r1985710577
##########
datafusion/physical-plan/src/stream.rs:
##########
@@ -241,8 +245,21 @@ impl RecordBatchReceiverStreamBuilder {
self.inner.spawn(task)
}
- /// Spawn a blocking task that will be aborted if this builder (or the
stream
- /// built from it) are dropped
+ /// Spawn a blocking task tied to the builder and stream.
+ ///
+ /// # Drop / Cancel Behavior
+ ///
+ /// If this builder (or the stream built from it) is dropped **before** the
+ /// task starts, the task is also dropped and will never start execute.
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
