timsaucer commented on PR #1041: URL: https://github.com/apache/datafusion-python/pull/1041#issuecomment-2702330600
We have 3 PRs that are all impacting the `__repr__` and `_repr_html_`. We have: - This one which does the additional data checking with a collect() - #1015 which collects until we get to 10 rows - #1036 which collects 2MB or 20 rows but just for the html rendering I suggest we consolidate. My proposal is: - we merge in #1015 as it is - I update #1036 to combine the collecting operations to be either by minimum number of rows or data size - We close #1041 in favor of the truncation message from 1036 (I'll add it to `__repr__` also. Does this sound reasonable? Also, its incredible to have so many people pitching in at the same time. I will try to spend some time this weekend to organize some of the open issues to make it easier to not duplicate effort. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
