alamb commented on code in PR #15051:
URL: https://github.com/apache/datafusion/pull/15051#discussion_r1984104647
##########
datafusion/optimizer/src/simplify_expressions/simplify_exprs.rs:
##########
@@ -62,8 +62,7 @@ impl OptimizerRule for SimplifyExpressions {
true
}
- /// if supports_owned returns true, the Optimizer calls
- /// [`Self::rewrite`] instead of [`Self::try_optimize`]
+ /// if supports_owned returns true, the Optimizer calls [`Self::rewrite`]
Review Comment:
I don't understand what this comments means anymore -- I think we can simply
delete it
##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -107,7 +89,7 @@ pub trait OptimizerRule: Debug {
/// if the plan was rewritten and `Transformed::no` if it was not.
///
/// Note: this function is only called if [`Self::supports_rewrite`]
returns
Review Comment:
I think after this PR `supports_rewrite` becomes a noop (doesn't do
anything) so I recommend we also mark it as deprecated as well (deprecated as
of 47.0.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
