alamb commented on code in PR #15051:
URL: https://github.com/apache/datafusion/pull/15051#discussion_r1985148749
##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -304,43 +284,25 @@ impl TreeNodeRewriter for Rewriter<'_> {
fn f_down(&mut self, node: LogicalPlan) ->
Result<Transformed<LogicalPlan>> {
if self.apply_order == ApplyOrder::TopDown {
- optimize_plan_node(node, self.rule, self.config)
+ {
Review Comment:
minor is that it is strange to have this second level of nesting braces --
we can remove it as a follow on PR I think
##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -99,15 +81,13 @@ pub trait OptimizerRule: Debug {
}
/// Does this rule support rewriting owned plans (rather than by
reference)?
Review Comment:
💯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
