mvzink commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1985755405
##########
src/ast/mod.rs:
##########
@@ -5334,6 +5345,16 @@ impl fmt::Display for Statement {
Statement::List(command) => write!(f, "LIST {command}"),
Statement::Remove(command) => write!(f, "REMOVE {command}"),
Statement::SetSessionParam(kind) => write!(f, "SET {kind}"),
+ Statement::SetVariables { variables, values } => {
+ write!(f, "SET ")?;
+ variables
+ .iter()
+ .zip(values.iter())
+ .map(|(var, val)| format!("{var} = {val}"))
+ .collect::<Vec<_>>()
+ .join(", ")
Review Comment:
I think you could use `display_comma_separated` for this
##########
tests/sqlparser_common.rs:
##########
@@ -14654,3 +14640,19 @@ fn parse_set_names() {
dialects.verified_stmt("SET NAMES 'utf8'");
dialects.verified_stmt("SET NAMES UTF8 COLLATE bogus");
}
+
+#[test]
+fn parse_multiple_set_statements() -> Result<(), ParserError> {
+ let dialects = all_dialects_where(|d|
d.supports_comma_separated_set_assignments());
+ let stmt = dialects.verified_stmt("SET @a = 1, b = 2");
Review Comment:
Nice. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
