iffyio commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1986233456
##########
src/ast/mod.rs:
##########
@@ -2947,6 +2947,17 @@ pub enum Statement {
variables: OneOrManyWithParens<ObjectName>,
value: Vec<Expr>,
},
+
+ /// ```sql
+ /// SET <variable> = expression [, <variable> = expression]*;
+ /// ```
+ ///
+ /// Note: this is a MySQL-specific statement.
+ /// Refer to [`Dialect.supports_comma_separated_set_assignments`]
+ SetVariables {
+ variables: Vec<ObjectName>,
+ values: Vec<Expr>,
+ },
Review Comment:
Thanks for clarify @mvzink! Introducing the `SetVariable` enum as above to
the handle the different representations sounds reasonable to me.
I'm not sure it necessarily needs to be done as a follow up PR given the
current PR would be introducing a new statement variant that is already on its
way out, maybe we can make changes to the effect in this PR?
@MohamedAbdeen21 wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
