2010YOUY01 commented on code in PR #15084:
URL: https://github.com/apache/datafusion/pull/15084#discussion_r1986026452


##########
datafusion/sqllogictest/test_files/explain_tree.slt:
##########
@@ -519,6 +519,36 @@ physical_plan
 17)│       format: arrow       │
 18)└───────────────────────────┘
 
+
+# Query with window agg.
+query TT
+explain select count(*) over() from table1;
+----
+logical_plan
+01)Projection: count(Int64(1)) ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED 
FOLLOWING AS count(*) ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING
+02)--WindowAggr: windowExpr=[[count(Int64(1)) ROWS BETWEEN UNBOUNDED PRECEDING 
AND UNBOUNDED FOLLOWING]]
+03)----TableScan: table1 projection=[]
+physical_plan
+01)┌───────────────────────────┐
+02)│       ProjectionExec      │
+03)└─────────────┬─────────────┘
+04)┌─────────────┴─────────────┐

Review Comment:
   To also test `BoundedWindowAggExec`, we can set a bounded window frame (e.g. 
'rows between 1 preceding and current row`)
   ```
    explain SELECT
       v1,
       SUM(v1) OVER (ORDER BY v1 ROWS BETWEEN 1 PRECEDING AND CURRENT ROW) AS 
rolling_sum
   FROM generate_series(1, 1000) AS t1(v1);
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to