irenjj commented on PR #15084: URL: https://github.com/apache/datafusion/pull/15084#issuecomment-2708162588
> Thank you so much for the efforts, I think the only thing missing is adding test for `BoundedWindowAggExec` > > DuckDB also uses the whole window expression in their pretty explain, this is good enough: > > ``` > ┌─────────────┴─────────────┐ > │ WINDOW │ > │ ──────────────────── │ > │ Projections: │ > │ sum(v1) OVER (ORDER BY v1 │ > │ ASC NULLS LAST ROWS │ > │ BETWEEN UNBOUNDED │ > │ PRECEDING AND CURRENT ROW)│ > └─────────────┬─────────────┘ > ``` > > But I think if we can split window-expr, partition-by, order-by, window-frame to separate rows, it will look even better: > > ``` > window expression: SUM(v1) OVER (...) > window frame: ROWS BETWEEN 1 PRECEDING AND CURRENT ROW > partition by: v1 % 10 > order by: v1 ASC NULLS LAST > ``` > > I think this should be left to a separate follow-up ticket, I saw `BoundedWindowExec` can have multiple window expressions, they should all have the same partition and order? This should be checked first and then figure out how to better format it. Thanks for you excellent advice!❤️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
