alamb commented on code in PR #14922: URL: https://github.com/apache/datafusion/pull/14922#discussion_r1986062324
########## datafusion/sqllogictest/test_files/aggregates_topk.slt: ########## @@ -110,11 +110,11 @@ logical_plan physical_plan 01)SortPreservingMergeExec: [max(traces.timestamp)@1 DESC], fetch=4 02)--SortExec: TopK(fetch=4), expr=[max(traces.timestamp)@1 DESC], preserve_partitioning=[true] -03)----AggregateExec: mode=FinalPartitioned, gby=[trace_id@0 as trace_id], aggr=[max(traces.timestamp)], lim=[4] +03)----AggregateExec: mode=FinalPartitioned, gby=[trace_id@0 as trace_id], aggr=[max(traces.timestamp)] 04)------CoalesceBatchesExec: target_batch_size=8192 05)--------RepartitionExec: partitioning=Hash([trace_id@0], 4), input_partitions=4 06)----------RepartitionExec: partitioning=RoundRobinBatch(4), input_partitions=1 -07)------------AggregateExec: mode=Partial, gby=[trace_id@0 as trace_id], aggr=[max(traces.timestamp)], lim=[4] +07)------------AggregateExec: mode=Partial, gby=[trace_id@0 as trace_id], aggr=[max(traces.timestamp)] Review Comment: I think it is because there is special topk functionality for aggregates: https://github.com/apache/datafusion/blob/main/datafusion/physical-plan/src/aggregates/topk/mod.rs This special implementation likely doesn't have support for Utf8View ########## datafusion/sqllogictest/test_files/aggregate_skip_partial.slt: ########## @@ -289,14 +289,8 @@ SELECT c2, approx_median(c5), approx_median(c11) FROM aggregate_test_100 GROUP B 5 593204320 0.5156586 # Test approx_distinct for varchar / int -query III +query error DataFusion error: This feature is not implemented: Support for 'approx_distinct' for data type Utf8View is not implemented Review Comment: This would be needed too -- added a note to - https://github.com/apache/datafusion/issues/15096 ########## datafusion/core/src/datasource/listing/table.rs: ########## @@ -1898,6 +1898,9 @@ mod tests { Ok(()) } + /// Note: We now default to use Utf8View, but we don't support for Utf8View in JSON reader Review Comment: - The follow on ticket is here: https://github.com/apache/arrow-rs/issues/7244 ########## datafusion/sqllogictest/test_files/window.slt: ########## @@ -3627,10 +3625,15 @@ physical_plan 07)------------StreamingTableExec: partition_sizes=1, projection=[a0, a, b, c, d], infinite_source=true, output_orderings=[[a@1 ASC NULLS LAST, b@2 ASC NULLS LAST], [c@3 ASC NULLS LAST]] # CTAS with NTILE function -statement ok +statement error Review Comment: this looks like a regression to me ########## datafusion/sqllogictest/test_files/avro.slt: ########## @@ -124,69 +124,24 @@ STORED AS AVRO LOCATION '../../testing/data/avro/simple_fixed.avro'; # test avro query -query IT +query error DataFusion error: Arrow error: Schema error: type Utf8View not supported Review Comment: 🤔 looks like we need to support Utf8View for avro as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
