zhuqi-lucas commented on issue #15096: URL: https://github.com/apache/datafusion/issues/15096#issuecomment-2708780286
I also testing the tcph, it seems also performance improvement which we use sql varchar to default to Utf8View. ```rust ./benchmarks/bench.sh compare main issue_14909 Comparing main and issue_14909 -------------------- Benchmark tpch_sf1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main ┃ issue_14909 ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 1 │ 72.78ms │ 70.32ms │ no change │ │ QQuery 2 │ 27.64ms │ 26.30ms │ no change │ │ QQuery 3 │ 37.75ms │ 38.22ms │ no change │ │ QQuery 4 │ 27.97ms │ 28.27ms │ no change │ │ QQuery 5 │ 52.59ms │ 49.36ms │ +1.07x faster │ │ QQuery 6 │ 20.81ms │ 20.66ms │ no change │ │ QQuery 7 │ 70.44ms │ 75.06ms │ 1.07x slower │ │ QQuery 8 │ 48.32ms │ 49.02ms │ no change │ │ QQuery 9 │ 62.60ms │ 63.14ms │ no change │ │ QQuery 10 │ 55.94ms │ 58.75ms │ 1.05x slower │ │ QQuery 11 │ 19.44ms │ 21.21ms │ 1.09x slower │ │ QQuery 12 │ 36.59ms │ 37.42ms │ no change │ │ QQuery 13 │ 34.05ms │ 34.88ms │ no change │ │ QQuery 14 │ 26.50ms │ 26.77ms │ no change │ │ QQuery 15 │ 42.97ms │ 45.06ms │ no change │ │ QQuery 16 │ 19.25ms │ 20.02ms │ no change │ │ QQuery 17 │ 73.64ms │ 68.81ms │ +1.07x faster │ │ QQuery 18 │ 96.62ms │ 95.08ms │ no change │ │ QQuery 19 │ 46.77ms │ 45.75ms │ no change │ │ QQuery 20 │ 45.54ms │ 40.98ms │ +1.11x faster │ │ QQuery 21 │ 95.29ms │ 95.19ms │ no change │ │ QQuery 22 │ 18.34ms │ 17.99ms │ no change │ └──────────────┴─────────┴─────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ Total Time (main) │ 1031.87ms │ │ Total Time (issue_14909) │ 1028.26ms │ │ Average Time (main) │ 46.90ms │ │ Average Time (issue_14909) │ 46.74ms │ │ Queries Faster │ 3 │ │ Queries Slower │ 3 │ │ Queries with No Change │ 16 │ └────────────────────────────┴───────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
