Spaarsh commented on code in PR #1059: URL: https://github.com/apache/datafusion-python/pull/1059#discussion_r1990014412
########## python/datafusion/expr.py: ########## @@ -86,6 +86,7 @@ Partitioning = expr_internal.Partitioning Placeholder = expr_internal.Placeholder Projection = expr_internal.Projection +RawExpr = expr_internal.RawExpr Review Comment: Something along these lines? ``` # Skip internal context and RawExpr (which is handled by Expr class) if attr in ["_global_ctx", "RawExpr"]: continue # Check if RawExpr functionality is covered by Expr class if attr == "RawExpr" and hasattr(wrapped_obj, "Expr"): expr_class = getattr(wrapped_obj, "Expr") assert hasattr(expr_class, "raw_expr"), "Expr class must provide raw_expr property" continue ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org