Spaarsh commented on code in PR #1059:
URL:
https://github.com/apache/datafusion-python/pull/1059#discussion_r1991354473
##########
python/datafusion/expr.py:
##########
@@ -102,6 +102,7 @@
__all__ = [
"Expr",
+ "RawExpr",
Review Comment:
i added a line in the test:
```
if isinstance(internal_attr, list):
assert isinstance(wrapped_attr, list)
for val in internal_attr:
if isinstance(val, str) and val.startswith("Raw"): #<----
added this line since we check for all Raw* classes in the previous part of the
code
continue
assert val in wrapped_attr
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
