blaginin commented on code in PR #15165:
URL: https://github.com/apache/datafusion/pull/15165#discussion_r1990159130
##########
datafusion/core/tests/dataframe/mod.rs:
##########
@@ -429,16 +434,16 @@ async fn drop_with_quotes() -> Result<()> {
let df_results = df.collect().await?;
- assert_batches_sorted_eq!(
Review Comment:
(here and everywhere else) `batches_to_sort_string` order has changed
changed because rhs is order-sensitive (since it's a string). there's a way to
overcome this
(https://github.com/apache/datafusion/pull/15165/files#r1990156623) but IMO
as-is is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
