berkaysynnada commented on code in PR #15165:
URL: https://github.com/apache/datafusion/pull/15165#discussion_r1991123800
##########
datafusion/core/tests/dataframe/mod.rs:
##########
@@ -79,21 +80,18 @@ use datafusion_expr::{
use datafusion_physical_expr::expressions::Column;
use datafusion_physical_expr::Partitioning;
use datafusion_physical_expr_common::physical_expr::PhysicalExpr;
-use datafusion_physical_plan::{get_plan_string, ExecutionPlanProperties};
+use datafusion_physical_plan::{displayable, ExecutionPlanProperties};
// Get string representation of the plan
-async fn assert_physical_plan(df: &DataFrame, expected: Vec<&str>) {
+async fn physical_plan_to_string(df: &DataFrame) -> String {
Review Comment:
This name sounds like `(Arc<dyn ExecutionPlan>) -> (String)`. Perhaps we can
make this a method of Dataframe, and call it something like
"to_physical_plan_string". WDYT?
##########
datafusion/core/tests/dataframe/mod.rs:
##########
@@ -429,16 +434,16 @@ async fn drop_with_quotes() -> Result<()> {
let df_results = df.collect().await?;
- assert_batches_sorted_eq!(
Review Comment:
Why don't we first sort the batches and then convert to strings? so the
orders are preserved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
