timsaucer commented on code in PR #1059:
URL:
https://github.com/apache/datafusion-python/pull/1059#discussion_r1991551933
##########
python/tests/test_wrapper_coverage.py:
##########
@@ -51,6 +58,8 @@ def missing_exports(internal_obj, wrapped_obj) -> None:
if isinstance(internal_attr, list):
assert isinstance(wrapped_attr, list)
for val in internal_attr:
+ if isinstance(val, str) and val.startswith("Raw"):
+ continue
Review Comment:
The previous part catches that the class is exposed, but this portion of the
test was, if my memory is correct, to ensure that everything that is in
`__all__` in the internal is also in the wrapper. Possibly I need to document
all of the reasons for the portions of that test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
