alamb commented on PR #15119: URL: https://github.com/apache/datafusion/pull/15119#issuecomment-2718998618
> @alamb Sure, I maybe write an example to demonstrate how why the newly added expr_planners method is helpful What I am thinking is "how will we ensure that we don't accidentally break this feature during future refactors" As it stands now, we could potentially break the feature without any tests failing Ideally we would have some test that fails so we would know to fix it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org