jayzhan211 opened a new issue, #15218:
URL: https://github.com/apache/datafusion/issues/15218

   ### Describe the bug
   
   ```rust
   #[tokio::test]
   async fn select_all() -> Result<()> {
       // build plan using `select_expr``
       let t = test_table().await?;
   
       let df = t
       .select(vec![wildcard()])?;
   
       let plan = df
           .logical_plan().clone();
       
       let r = df.collect().await?;
       println!("r: {:?}", r);
   
   
       println!("paln: {}", plan.display_indent());
   
       Ok(())
   }
   ```
   
   This query is no longer working after 
https://github.com/apache/datafusion/pull/15170/files. I didn't notice 
Dataframe case but only sql case.
   
   But given `Expr::Wildcard` is deprecated, we need to find alternative way to 
support wildcard. 
   
   One way is to add WildcardOptions
   
   ```rust
       pub fn try_new_with_schema(
           expr: Vec<Expr>,
           wildcard: Option<WildcardOptions>,
           input: Arc<LogicalPlan>,
           schema: DFSchemaRef,
       ) -> Result<Self>
   ``` 
   
   or maybe a new Enum
   
   ```rust
   enum ProjectionExprs {
       /// The expressions are provided as a list of expressions
       Exprs(Vec<Expr>),
       /// The expressions are provided as a wildcard
       Wildcard(WildcardOptions),
   }
   ```
   
   However, both require API change
   
   ### To Reproduce
   
   _No response_
   
   ### Expected behavior
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to