shehabgamin commented on code in PR #15168:
URL: https://github.com/apache/datafusion/pull/15168#discussion_r1994823297
##########
datafusion/core/src/execution/session_state_defaults.rs:
##########
@@ -104,28 +104,55 @@ impl SessionStateDefaults {
/// returns the list of default [`ScalarUDF']'s
pub fn default_scalar_functions() -> Vec<Arc<ScalarUDF>> {
- #[cfg_attr(not(feature = "nested_expressions"), allow(unused_mut))]
+ #[cfg_attr(
+ not(any(feature = "nested_expressions", feature = "spark")),
+ allow(unused_mut)
+ )]
let mut functions: Vec<Arc<ScalarUDF>> =
functions::all_default_functions();
#[cfg(feature = "nested_expressions")]
functions.append(&mut
functions_nested::all_default_nested_functions());
+ #[cfg(feature = "spark")]
+ functions.append(&mut
datafusion_spark::all_default_scalar_functions());
+
Review Comment:
I don't have a strong opinion on this either. I'm open to alternatives.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
