shruti2522 commented on PR #15217: URL: https://github.com/apache/datafusion/pull/15217#issuecomment-2725633230
> Thank you @shruti2522 🙏 > > The only concern I have about this PR is that now overlay() is not listed as a string function, which is kind of strange. > > It also means that anyone who uses`overlay` in their project would have to change the `use` path. > > I wonder if it would be possible to also have it listed with the string functions (as well as core)) maybe by re-exporting it in `datafusion-functions/string` somehow 🤔 hey @alamb, I have already added a re-export at the end of `datafusion/functions/src/string/overlay.rs` like this ```rust pub use crate::core::overlay::*; ``` Maybe, I should remove the deprecation statement for overlay() in `string.rs`. Should we consider a different approach for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
