Re: [PR] Saner handling of nulls inside arrays [datafusion]

[via GitHub]

jayzhan211 commented on code in PR #15149:
URL: https://github.com/apache/datafusion/pull/15149#discussion_r1996515968


##########
datafusion/expr/src/type_coercion/functions.rs:
##########
@@ -364,98 +366,73 @@ fn get_valid_types(
             return Ok(vec![vec![]]);
         }
 
-        let array_idx = arguments.iter().enumerate().find_map(|(idx, arg)| {
-            if *arg == ArrayFunctionArgument::Array {
-                Some(idx)
-            } else {
-                None
-            }
-        });
-        let Some(array_idx) = array_idx else {
-            return Err(internal_datafusion_err!("Function '{function_name}' 
expected at least one argument array argument"));
-        };
-        let Some(array_type) = array(&current_types[array_idx]) else {
-            return Ok(vec![vec![]]);
-        };
+        let mut fixed_size = None;
+        let mut large_list = false;
+        let mut element_types = Vec::with_capacity(arguments.len());
+        for (argument, current_type) in 
arguments.iter().zip(current_types.iter()) {
+            match argument {
+                ArrayFunctionArgument::Array => match current_type {
+                    DataType::FixedSizeList(field, size) => {
+                        match array_coercion {
+                            Some(ListCoercion::FixedSizedListToList) => (),
+                            None if fixed_size.is_none() => fixed_size = 
Some(*size),
+                            None if fixed_size == Some(*size) => (),

Review Comment:
   But return the `current_type` makes more sense.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org