jayzhan211 commented on code in PR #15149:
URL: https://github.com/apache/datafusion/pull/15149#discussion_r1996471597
##########
datafusion/expr-common/src/signature.rs:
##########
@@ -865,6 +867,39 @@ impl Signature {
volatility,
}
}
+
+ /// Specialized Signature for ArrayPrepend and similar functions
+ pub fn element_and_array(volatility: Volatility) -> Self {
+ Signature {
+ type_signature: TypeSignature::ArraySignature(
+ ArrayFunctionSignature::Array {
+ arguments: vec![
+ ArrayFunctionArgument::Element,
+ ArrayFunctionArgument::Array,
+ ],
+ array_coercion: Some(ListCoercion::FixedSizedListToList),
Review Comment:
What we need is to provide customizable signature, so if they want List for
append, they can add `array_coercion:
Some(ListCoercion::FixedSizedListToList)`, if they want to keep fixed-size-list
they can add `array_coercion: None`. Both cases should be possible.
For datafusion implementation, we choose to convert to List by default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
