mbrobbel commented on code in PR #14967: URL: https://github.com/apache/datafusion/pull/14967#discussion_r1998296079
########## datafusion/core/tests/parquet/filter_pushdown.rs: ########## @@ -65,7 +65,12 @@ fn generate_file(tempdir: &TempDir, props: WriterProperties) -> TestParquetFile test_parquet_file } -#[tokio::test] +// The result can be flaky if `rand` crate updated. +// +// Reason: Data generated by Review Comment: I noticed the same (in https://github.com/apache/datafusion/pull/14447) for some different tests, which I fixed by explicitly using `rand_chacha`: e.g. https://github.com/apache/datafusion/pull/14447/files#diff-4a599584dfc900ec21169f4f820a1b1db46b004b77533dab83a6178d5d3a467eR4253 following https://rust-random.github.io/book/crate-reprod.html. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org