alamb commented on code in PR #15268:
URL: https://github.com/apache/datafusion/pull/15268#discussion_r1999148261
##########
datafusion/datasource-parquet/src/file_format.rs:
##########
@@ -465,45 +465,103 @@ impl FileFormat for ParquetFormat {
}
}
-/// Coerces the file schema if the table schema uses a view type.
-pub fn coerce_file_schema_to_view_type(
Review Comment:
Since these two APIs are `pub`:
-
https://docs.rs/datafusion/latest/datafusion/?search=coerce_file_schema_to_view_type
-
https://docs.rs/datafusion/latest/datafusion/?search=coerce_file_schema_to_string_type
I think it would be best if you could add back in the existing functions
(that called this nice new one) / siganatures and mark them deprecated, per the
guidelines:
https://datafusion.apache.org/contributor-guide/api-health.html#deprecation-guidelines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
