m09526 commented on code in PR #15268: URL: https://github.com/apache/datafusion/pull/15268#discussion_r1998724986
########## datafusion/datasource-parquet/src/file_format.rs: ########## @@ -465,45 +465,103 @@ impl FileFormat for ParquetFormat { } } -/// Coerces the file schema if the table schema uses a view type. -pub fn coerce_file_schema_to_view_type( +/// Apply necessary schema type coercions between table and file schemas +/// Review Comment: Perhaps clarify top line of documentation to say "Apply necessary schema type coercions to make file schema match table schema." "Between" implies function will perform conversion both ways. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org