alamb commented on code in PR #15275:
URL: https://github.com/apache/datafusion/pull/15275#discussion_r1999247151
##########
datafusion/expr-common/src/type_coercion/binary.rs:
##########
@@ -1177,26 +1177,6 @@ pub fn string_coercion(lhs_type: &DataType, rhs_type:
&DataType) -> Option<DataT
}
}
-/// This will be deprecated when binary operators native support
Review Comment:
outstanding ❤️
##########
datafusion/sqllogictest/test_files/string/string_view.slt:
##########
@@ -1100,7 +1100,7 @@ EXPLAIN SELECT
FROM test;
----
logical_plan
-01)Projection: CAST(test.column1_utf8view AS Utf8) LIKE Utf8("%an%") AS c1
+01)Projection: test.column1_utf8view ~ Utf8View("an") AS c1
Review Comment:
looks good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
