suibianwanwank commented on code in PR #15281:
URL: https://github.com/apache/datafusion/pull/15281#discussion_r1999272559
##########
datafusion/optimizer/src/scalar_subquery_to_join.rs:
##########
@@ -476,19 +485,19 @@ mod tests {
.build()?;
let expected = "Projection: customer.c_custkey [c_custkey:Int64]\
- \n Filter: customer.c_acctbal <
__scalar_sq_1.sum(orders.o_totalprice) [c_custkey:Int64, c_name:Utf8,
sum(orders.o_totalprice):Float64;N, o_custkey:Int64;N]\
- \n Left Join: Filter: __scalar_sq_1.o_custkey = customer.c_custkey
[c_custkey:Int64, c_name:Utf8, sum(orders.o_totalprice):Float64;N,
o_custkey:Int64;N]\
- \n TableScan: customer [c_custkey:Int64, c_name:Utf8]\
- \n SubqueryAlias: __scalar_sq_1
[sum(orders.o_totalprice):Float64;N, o_custkey:Int64]\
- \n Projection: sum(orders.o_totalprice), orders.o_custkey
[sum(orders.o_totalprice):Float64;N, o_custkey:Int64]\
- \n Aggregate: groupBy=[[orders.o_custkey]],
aggr=[[sum(orders.o_totalprice)]] [o_custkey:Int64,
sum(orders.o_totalprice):Float64;N]\
- \n Filter: orders.o_totalprice <
__scalar_sq_2.sum(lineitem.l_extendedprice) [o_orderkey:Int64, o_custkey:Int64,
o_orderstatus:Utf8, o_totalprice:Float64;N,
sum(lineitem.l_extendedprice):Float64;N, l_orderkey:Int64;N]\
- \n Left Join: Filter: __scalar_sq_2.l_orderkey =
orders.o_orderkey [o_orderkey:Int64, o_custkey:Int64, o_orderstatus:Utf8,
o_totalprice:Float64;N, sum(lineitem.l_extendedprice):Float64;N,
l_orderkey:Int64;N]\
- \n TableScan: orders [o_orderkey:Int64,
o_custkey:Int64, o_orderstatus:Utf8, o_totalprice:Float64;N]\
- \n SubqueryAlias: __scalar_sq_2
[sum(lineitem.l_extendedprice):Float64;N, l_orderkey:Int64]\
- \n Projection: sum(lineitem.l_extendedprice),
lineitem.l_orderkey [sum(lineitem.l_extendedprice):Float64;N, l_orderkey:Int64]\
- \n Aggregate: groupBy=[[lineitem.l_orderkey]],
aggr=[[sum(lineitem.l_extendedprice)]] [l_orderkey:Int64,
sum(lineitem.l_extendedprice):Float64;N]\
- \n TableScan: lineitem [l_orderkey:Int64,
l_partkey:Int64, l_suppkey:Int64, l_linenumber:Int32, l_quantity:Float64,
l_extendedprice:Float64]";
+ \n Filter: customer.c_acctbal <
__scalar_sq_1.sum(orders.o_totalprice) [c_custkey:Int64, c_name:Utf8,
sum(orders.o_totalprice):Float64;N, o_custkey:Int64;N, __always_true:Boolean;N]\
Review Comment:
These plan changes are due to redundant columns. It will be trimmed later in
the optimization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
