alamb commented on PR #15253: URL: https://github.com/apache/datafusion/pull/15253#issuecomment-2734461898
> Thanks @alamb, @jayzhan211 and @xudong963 for your review, here are two points that remain unclear: > > 1. For GROUP BY, is it necessary to preserve the row index -- for more information, additional functionality, or just better aesthetics? I think it is for aesthetics only > Is it possible to modify Display for Expr for explain statement? > 2. Should the default Display implementation of Expr be modified to replace SqlDisplay? I think this would be a more disruptive change as it would change the existing `EXPLAIN ...` output. Thus I think we should consider it as a follow on PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
