geoffreyclaude commented on PR #14547: URL: https://github.com/apache/datafusion/pull/14547#issuecomment-2739859432
@alamb and @goldmedal thanks for the review! > From my perspective this PR now closes that issue's stated request: > > > I would like to make it easy for people to add DataFusion ExecutionPlan level tracing to their systems as well. > > Is it ok if we close it as well after this is merged? Ok for me at least! There'll probably be some minor adjustments to make once we start playing with it (maybe some other futures to wrap, for instance in `ListingTable::list_files_for_scan` the `future::try_join_all` and `StreamExt::buffer_unordered` might cause `tokio` to schedule on separate threads), but I think the core problem is solved for ExecutionPath tracing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
