shruti2522 commented on code in PR #15322:
URL: https://github.com/apache/datafusion/pull/15322#discussion_r2006224462


##########
datafusion/functions-aggregate/src/min_max.rs:
##########
@@ -264,6 +265,7 @@ impl AggregateUDFImpl for Max {
                 | Binary
                 | LargeBinary
                 | BinaryView
+                | Duration(_)

Review Comment:
   > I think you need to add `Duration` to the list of types supported in 
`groups_accumulator_supported` as well.
   
   Hi @alamb, I have added it here and similarly for `Min`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to