Re: [PR] fix type coercion for uint/int's [datafusion]

Fri, 21 Mar 2025 08:06:35 -0700 


berkaysynnada commented on code in PR #15341:
URL: https://github.com/apache/datafusion/pull/15341#discussion_r2007781920


##########
datafusion/expr-common/src/type_coercion/binary.rs:
##########
@@ -855,21 +855,14 @@ pub fn binary_numeric_coercion(
         (UInt64, _) | (_, UInt64) => Some(UInt64),
         (Int64, _)
         | (_, Int64)
-        | (UInt32, Int8)
-        | (Int8, UInt32)
-        | (UInt32, Int16)
-        | (Int16, UInt32)
-        | (UInt32, Int32)
-        | (Int32, UInt32) => Some(Int64),

Review Comment:
   > I wanted to emphasize this removed line, as it seemed to me that it is 
already the same of your intention: <img alt="image" width="453" 
src="https://private-user-images.githubusercontent.com/124376117/425523556-bdddeaf2-5940-46be-bed8-b89ef57d92b6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDI1Njk2MjMsIm5iZiI6MTc0MjU2OTMyMywicGF0aCI6Ii8xMjQzNzYxMTcvNDI1NTIzNTU2LWJkZGRlYWYyLTU5NDAtNDZiZS1iZWQ4LWI4OWVmNTdkOTJiNi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMzIxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDMyMVQxNTAyMDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iYzRhYTE2MjJlMjFlMzk1NWM5NGJkM2M0NzNhNDg4YWQ5MGNiNWZlZGQ5Mzk5ODllNTQwZTUyOTc1Y2QwMWE1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.XGFOfChDxTxNJZdTxWAoOVWre2oZeAi6qF7ueg3XK1Q";>
   > 
   > but I looked more and see:
   > 
   > 1. binary_numeric_coercion(): as I can see, you only did a refactor. There 
is a logical change there?
   > 2. mathematics_numerical_coercion(): which was the inaccurate part, and 
you are updating the code such that it has the same behavior with 
binary_numeric_coercion().
   > 
   > IIUC, the change makes sense. Further, instead of duplicating these huge 
match arm, can we unify them into 1 function?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to