alamb commented on code in PR #15361:
URL: https://github.com/apache/datafusion/pull/15361#discussion_r2009203333
##########
datafusion/functions/src/datetime/to_char.rs:
##########
@@ -277,7 +282,25 @@ fn _to_char_array(args: &[ColumnarValue]) ->
Result<ColumnarValue> {
let result = formatter.value(idx).try_to_string();
match result {
Ok(value) => results.push(Some(value)),
- Err(e) => return exec_err!("{}", e),
+ Err(e) => {
+ if data_type == &Date32 {
Review Comment:
I don't understand why this is handling errors -- shouldn't we just dispach
on type when building the format options?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
