friendlymatthew commented on code in PR #15361:
URL: https://github.com/apache/datafusion/pull/15361#discussion_r2019270254
##########
datafusion/functions/src/datetime/to_char.rs:
##########
@@ -277,7 +282,25 @@ fn _to_char_array(args: &[ColumnarValue]) ->
Result<ColumnarValue> {
let result = formatter.value(idx).try_to_string();
match result {
Ok(value) => results.push(Some(value)),
- Err(e) => return exec_err!("{}", e),
+ Err(e) => {
+ if data_type == &Date32 {
Review Comment:
> Casting Date32 to Date64 should be incredibly cheap I think
I agree, converting involves a cast between primitives and a mult.
https://github.com/apache/arrow-rs/blob/206fe024cdd9b9de770714baa27b58a1442fcc75/arrow-cast/src/cast/mod.rs#L1423-L1427
> Yeah, this is a limitation of arrow-rs currently. I never got around to
pushing a PR to arrow-rs to change that.
I'd be happy to work on this next, if you'd like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
