mertak-synnada commented on code in PR #15352:
URL: https://github.com/apache/datafusion/pull/15352#discussion_r2009572413


##########
datafusion-examples/examples/parquet_index.rs:
##########
@@ -244,9 +244,10 @@ impl TableProvider for IndexTableProvider {
         let source =
             Arc::new(ParquetSource::default().with_predicate(self.schema(), 
predicate));
         let mut file_scan_config =
-            FileScanConfig::new(object_store_url, self.schema(), source)
+            FileScanConfigBuilder::new(object_store_url, self.schema(), source)
                 .with_projection(projection.cloned())
-                .with_limit(limit);
+                .with_limit(limit)
+                .build();

Review Comment:
   Looking good so far, thank you! I haven't been able to test it thoroughly 
yet, but the legacy `ParquetExecBuilder` could be helpful for understanding 
specific cases, just FYI.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to