blaginin opened a new pull request, #15352: URL: https://github.com/apache/datafusion/pull/15352
Related to https://github.com/apache/datafusion/pull/14685#issuecomment-2667684649 ## Rationale for this change `FileScanConfig` now violates single responsibility from SOLID. It serves two conflicting roles: - As a builder, though this should be changed as discussed in https://github.com/apache/datafusion/blob/635e73b6bf239364f369573185f07902acd0f021/datafusion/datasource/src/file_scan_config.rs#L631 - As a business logic provider (e.g., `fn project`, `impl DataSource`, etc.) These conflicting roles lead to issues like https://github.com/apache/datafusion/issues/14905 and https://github.com/apache/datafusion/issues/14679, where provider features are accessed even _before_ the build process is complete. ## What changes are included in this PR? I've added `FileScanConfigBuilder` and deprecated builder approach for `FileScanConfig` ## Are these changes tested? todo ## Are there any user-facing changes? todo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
