rkrishn7 commented on code in PR #15242: URL: https://github.com/apache/datafusion/pull/15242#discussion_r2011223823
########## datafusion/sqllogictest/test_files/union_by_name.slt: ########## @@ -152,22 +152,22 @@ NULL 4 # Limit query III -SELECT 1 UNION BY NAME SELECT * FROM unnest(range(2, 100)) UNION BY NAME SELECT 999 ORDER BY 3, 1 LIMIT 5; +SELECT 1 UNION BY NAME SELECT * FROM unnest(range(2, 100)) UNION BY NAME SELECT 999 ORDER BY 3, 1, 2 LIMIT 5; ---- -NULL NULL 2 -NULL NULL 3 -NULL NULL 4 -NULL NULL 5 -NULL NULL 6 +NULL NULL 999 +1 NULL NULL +NULL 2 NULL +NULL 3 NULL +NULL 4 NULL query III SELECT 1 UNION ALL BY NAME SELECT * FROM unnest(range(2, 100)) UNION ALL BY NAME SELECT 999 ORDER BY 3, 1 LIMIT 5; ---- -NULL NULL 2 -NULL NULL 3 -NULL NULL 4 -NULL NULL 5 -NULL NULL 6 +NULL NULL 999 Review Comment: Same here - result set is changing due to column reordering. Also verified result is consistent with duckdb's. ########## datafusion/sqllogictest/test_files/union_by_name.slt: ########## @@ -152,22 +152,22 @@ NULL 4 # Limit query III -SELECT 1 UNION BY NAME SELECT * FROM unnest(range(2, 100)) UNION BY NAME SELECT 999 ORDER BY 3, 1 LIMIT 5; +SELECT 1 UNION BY NAME SELECT * FROM unnest(range(2, 100)) UNION BY NAME SELECT 999 ORDER BY 3, 1, 2 LIMIT 5; Review Comment: Previously the unnest column was incorrectly #3. Now it is correctly #2 so the result here has changed. The extra ordering is to order the unnest values for a deterministic result. Also verified result is consistent with duckdb's. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
