2010YOUY01 commented on PR #15266: URL: https://github.com/apache/datafusion/pull/15266#issuecomment-2749981776
I haven't been following the recent conversations regarding hashmap optimization, but I also feel, if it needs pre-aggregate to make the low-cardinality case run faster, there might be some inefficiency inside the global state update implementation. Since this PR already got significant performance improvement, we can play around with the further optimization in follow-up PRs, I plan to merge it shortly unless there are other considerations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
