danila-b commented on PR #15101: URL: https://github.com/apache/datafusion/pull/15101#issuecomment-2757347599
> I have completed testing in my fork and I agree this works ❤️ - thank you so much @danila-b (see testing PR here [alamb#33](https://github.com/alamb/datafusion/pull/33)) > > I also think we should add a note to the user docs about this awesome feature: https://datafusion.apache.org/contributor-guide/testing.html#extended-tests > > But we can do that as a follow on > > THanks again for this great feature and for your patience waiting on review Happy to help @alamb, I have pushed the comments that you suggested to this PR, it might need another approval to get merged since some actions need to be re-run I think. I don't know what the merge process is but feel free to merge it whenever convenient or get this across the finish line since I will be on vacation for the next couple of weeks 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
