Omega359 commented on code in PR #15361:
URL: https://github.com/apache/datafusion/pull/15361#discussion_r2020170477
##########
datafusion/functions/src/datetime/to_char.rs:
##########
@@ -220,6 +221,13 @@ fn _to_char_scalar(
}
}
+ // eagerly cast Date32 values to Date64 to support date formatting with
time-related specifiers
+ // without error.
+ if data_type == &Date32 {
Review Comment:
It is possible to check for time formats in the format string however I'm
not sure that cost would be any less than just doing the conversion up front. I
think we need a benchmark to have quantified data vs assumptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
