adriangb commented on code in PR #15301:
URL: https://github.com/apache/datafusion/pull/15301#discussion_r2021674359


##########
datafusion/datasource-parquet/src/source.rs:
##########
@@ -349,11 +337,13 @@ impl ParquetSource {
     }
 
     /// Optional reference to this parquet scan's pruning predicate
+    #[deprecated(note = "ParquetDataSource no longer constructs a 
PruningPredicate.")]
     pub fn pruning_predicate(&self) -> Option<&Arc<PruningPredicate>> {
         self.pruning_predicate.as_ref()

Review Comment:
   I wanted to do this as well but it broke several tests that rely on this. 
Are you okay with a larger diff to handle this? I was thinking we do it in a 
followup PR (I can make a ticket to track and deal with it right after this one 
is merged).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to